Skip to content

Refactor install_dependencies to use bash array#17

Merged
arkamar merged 2 commits intomainfrom
refactor/install-dependencies
Mar 24, 2026
Merged

Refactor install_dependencies to use bash array#17
arkamar merged 2 commits intomainfrom
refactor/install-dependencies

Conversation

@arkamar
Copy link
Copy Markdown
Contributor

@arkamar arkamar commented Mar 24, 2026

Use a bash array for the package list instead of a plain string to avoid word-splitting issues. Also sort packages alphabetically and move apt update before apt install for clarity.

arkamar added 2 commits March 24, 2026 13:42
Use an array instead of a plain string to avoid word-splitting issues
and move apt update before apt install for clarity.
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 24, 2026

PR Summary

Low Risk
Low risk refactor limited to build.sh dependency installation; behavior should be unchanged aside from safer argument handling and clearer ordering.

Overview
Refactors build.sh install_dependencies to build the apt package list as a bash array (including conditional gcc-aarch64-linux-gnu for cross-builds) and installs via apt install -y "${packages[@]}" to avoid word-splitting.

Also reorders the steps to run apt update immediately before apt install and normalizes the package list ordering for readability.

Written by Cursor Bugbot for commit 0d8dc0e. This will update automatically on new commits. Configure here.

@jakubno jakubno self-assigned this Mar 24, 2026
@arkamar arkamar merged commit 3d5a33a into main Mar 24, 2026
6 checks passed
@arkamar arkamar deleted the refactor/install-dependencies branch March 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants